Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for autoincrement columns #52

Merged
merged 3 commits into from
Sep 28, 2023

Conversation

lafriks
Copy link
Contributor

@lafriks lafriks commented Sep 26, 2023

Both ID and BigID will now map to INTEGER as SQLite3 supports only INTEGER auto increment columns

@lafriks lafriks added the enhancement New feature or request label Sep 26, 2023
go.mod Show resolved Hide resolved
@lafriks lafriks requested a review from Fs02 September 27, 2023 00:01
sqlite3.go Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
Copy link
Member

@Fs02 Fs02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks

@lafriks
Copy link
Contributor Author

lafriks commented Sep 28, 2023

@Fs02 can you please merge this?

@Fs02
Copy link
Member

Fs02 commented Sep 28, 2023

oh sorry, I thought I've merged this

@Fs02 Fs02 merged commit 9a585c6 into go-rel:main Sep 28, 2023
5 checks passed
@lafriks lafriks deleted the feat/column_options branch September 29, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants