Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests fail with Go 1.12 #184

Closed
AlekSi opened this issue Dec 9, 2018 · 0 comments
Closed

Tests fail with Go 1.12 #184

AlekSi opened this issue Dec 9, 2018 · 0 comments
Assignees
@AlekSi
Labels
chore
Milestone
v1.3.3

Comments

@AlekSi
Copy link
Member

AlekSi commented Dec 9, 2018

panic: Log in goroutine after has completed

That's another unfortunate side-effect of testify suites (#141). But maybe we can fix that without changing all tests.
@AlekSi AlekSi added this to the v1.4.0 milestone Dec 9, 2018
@AlekSi AlekSi self-assigned this Dec 10, 2018
AlekSi added a commit that referenced this issue Dec 10, 2018
@AlekSi
Unset logger once test is complete.
6b66521 
Closes #184.
@AlekSi AlekSi mentioned this issue Dec 10, 2018
Merged
AlekSi added a commit that referenced this issue Dec 10, 2018
@AlekSi
Unset logger once test is complete.
94fbbca 
Closes #184.
@AlekSi AlekSi mentioned this issue Dec 10, 2018
Merged
AlekSi added a commit that referenced this issue Dec 10, 2018
@AlekSi
Unset logger once test is complete.
de4e9c0 
Closes #184.
AlekSi added a commit that referenced this issue Dec 10, 2018
@AlekSi
Unset logger once test is complete.
b3073c0 
Closes #184.
@AlekSi AlekSi modified the milestones: v1.4.0, v1.3.3 Dec 10, 2018
@AlekSi AlekSi closed this as completed in bc19f84 Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlekSi AlekSi

Labels
chore
Projects
None yet
Milestone
v1.3.3
Development

No branches or pull requests
1 participant
@AlekSi