-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement github workflow events (Dispatch, Job, Run) #139
Implement github workflow events (Dispatch, Job, Run) #139
Conversation
7687e8d
to
2ba9f6e
Compare
Ok, this is hopefully ready for review now that I added in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for creating this PR! Would also like to see support for GitHub workflow events in this package.
Co-authored-by: Justin Toh <[email protected]>
41a190b
to
ffc40ad
Compare
Not sure what you mean... could you point me out to where these events are in the code base? I'm fairly new to the GitHub webhook stuff. |
Sorry, I meant to say that I would like to see your changes in this PR merged. (I believe you have already implemented all the workflow-based webhook events that GitHub supports) 😄 @deankarn @Toshik1978 By any chance either of you are free this week to review this? Thank you 🙏🏼 |
Ahhhhh ok... I thought it was something I was missing or something. |
Thanks @dvonthenen & @Toshik1978! |
This PR implements event processing for GitHub
workflow_dispatch
:https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#workflow_dispatch
workflow_job
:https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#workflow_job
and
workflow_run
:https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#workflow_run
This implementation has been verified in a production environment (https://github.com/vmware-tanzu/community-edition) and details on its use can be found in this PR: vmware-tanzu/community-edition#2300