Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Gitlab Job and Pipeline events #123

Merged
merged 1 commit into from
Jan 6, 2021

Conversation

shaheed121
Copy link

@shaheed121 shaheed121 commented Dec 22, 2020

Modify Pipeline events and Job events payload as per https://docs.gitlab.com/ee/user/project/integrations/webhooks.html

@shaheed121 shaheed121 changed the title Modify Job and Pipeline events as per https://docs.gitlab.com/ee/user… Modify Gitlab Job and Pipeline events Dec 22, 2020
@shaheed121 shaheed121 marked this pull request as ready for review December 22, 2020 17:27
@shaheed121
Copy link
Author

@Toshik1978 @deankarn Could you all take a look at this please?

@Toshik1978
Copy link
Contributor

@shaheed121 will review this week!

@Toshik1978
Copy link
Contributor

@shaheed121 interesting situation. Commonly your changes are backward incompatible. The question is how current code can be used at all... If smbd. by some reasons used it (it should not work, but...), than it's a problem )

…/project/integrations/webhooks.html

Also, modified dependent types like Repository, MergeRequest, Commit to reflect the latest payload.
@shaheed121
Copy link
Author

Changes to job events was merged in Gitlab on Aug 29, 2019. Also, changes to pipeline events to use builds instead of jobs happened on May 23, 2019. So it hasn't been working for a while. I have made more additions and removed deprecated keys that are not being in use.

@Toshik1978 So could you please release a major version release of the library with note on backward incompatible change for Gitlab?

@Toshik1978
Copy link
Contributor

@shaheed121 I'm almost agree with you. We already have several PRs with breaking changes. But I want to sync it with @deankarn. Dean, what do you think? I'm ready to release v6 commonly

@shaheed121
Copy link
Author

@Toshik1978 @deankarn Do you think you can provide some love to this? :)

Copy link
Collaborator

@deankarn deankarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Toshik1978 yes by all means if there are breaking changes let's release a new version :)
If you could try to get multiple breaking change PR's merged into the same release, that'd be ideal.

@Toshik1978
Copy link
Contributor

@deankarn yeap, definitely will review all latest PRs with incompatible changes and release at once!
@shaheed121 I'll try to release new major version this week.

@Toshik1978 Toshik1978 changed the base branch from v5 to v6 January 6, 2021 18:51
@Toshik1978 Toshik1978 merged commit b6a3080 into go-playground:v6 Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants