-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify Gitlab Job and Pipeline events #123
Conversation
@Toshik1978 @deankarn Could you all take a look at this please? |
@shaheed121 will review this week! |
@shaheed121 interesting situation. Commonly your changes are backward incompatible. The question is how current code can be used at all... If smbd. by some reasons used it (it should not work, but...), than it's a problem ) |
…/project/integrations/webhooks.html Also, modified dependent types like Repository, MergeRequest, Commit to reflect the latest payload.
02b467a
to
b79b935
Compare
Changes to job events was merged in Gitlab on Aug 29, 2019. Also, changes to pipeline events to use @Toshik1978 So could you please release a major version release of the library with note on backward incompatible change for Gitlab? |
@shaheed121 I'm almost agree with you. We already have several PRs with breaking changes. But I want to sync it with @deankarn. Dean, what do you think? I'm ready to release v6 commonly |
@Toshik1978 @deankarn Do you think you can provide some love to this? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Toshik1978 yes by all means if there are breaking changes let's release a new version :)
If you could try to get multiple breaking change PR's merged into the same release, that'd be ideal.
@deankarn yeap, definitely will review all latest PRs with incompatible changes and release at once! |
Modify Pipeline events and Job events payload as per https://docs.gitlab.com/ee/user/project/integrations/webhooks.html