Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitlab Merge Request Assignees #101

Closed
lsascha opened this issue Feb 22, 2020 · 1 comment
Closed

Gitlab Merge Request Assignees #101

lsascha opened this issue Feb 22, 2020 · 1 comment

Comments

@lsascha
Copy link

lsascha commented Feb 22, 2020

It seems that gitlab changed the place of asignees in the payload.
At least in my tests they are not in the ObjectAttributes.Assignee
I had to add an array of Assignee to the MergeRequestEventPayload to get them.

see my diff
https://github.com/lsascha/webhooks/commit/122aaa16423b41a7cbc31f3d69c8a55f93ef0b2a.diff

@lsascha lsascha changed the title Gitlab Merge Request Asignees Gitlab Merge Request Assignees Feb 22, 2020
@lsascha
Copy link
Author

lsascha commented Feb 22, 2020

Also i noticed that the Assignees also contain an email field.

So maybe also add

Email string `json:"email"`

to the Assignee struct if we are at it?

riyadhalnur added a commit to riyadhalnur/webhooks that referenced this issue May 2, 2021
- gitlab updated their MR payload which adds a parent field
for the list of assignees
- this fix update the Assignee struct to add the missing `Email`
and `ID` field
- adds an array of assignees as part of the MR event payload

Closes go-playground#101
riyadhalnur added a commit to riyadhalnur/webhooks that referenced this issue May 2, 2021
- gitlab updated their MR payload which adds a parent field
for the list of assignees
- this fix update the Assignee struct to add the missing `Email`
and `ID` field
- adds an array of assignees as part of the MR event payload

Closes go-playground#101
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants