added excluded_if/excluded_unless tags + tests #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
This would be useful, can someone please review this? |
deankarn
reviewed
Apr 19, 2022
baked_in.go
Outdated
| if len(params)%2 != 0 { | ||
| panic(fmt.Sprintf("Bad param number for excluded_unless %s", fl.FieldName())) | ||
| } | ||
| fmt.Println(params[0], params[1], requireCheckFieldValue(fl, params[0], params[1], false), !hasValue(fl)) |
There was a problem hiding this comment.
Yep, 100% a leftover. Pushed with changes.
I'll add a test for nested fields today (hopefully).
There was a problem hiding this comment.
OK, tests for nested (inner) structs were added.
Golangci-lint is very angry though, but locally runs fine (I'm running 1.45.2 though).
I also don't see a golangci lint yaml config in the root dir...
There was a problem hiding this comment.
@deankarn anything else I need to do for this?
deankarn
approved these changes
May 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Or Enhances
Adds
excluded_ifandexcluded_unlesstags with tests.Make sure that you've checked the boxes below before you submit PR:
@go-playground/validator-maintainers