Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve validation messages #44

Closed
14 tasks done
fredbi opened this issue Dec 18, 2017 · 1 comment
Closed
14 tasks done

Improve validation messages #44

fredbi opened this issue Dec 18, 2017 · 1 comment

Comments

@fredbi
Copy link
Member

fredbi commented Dec 18, 2017

We should improve the quality of messages reported by the validation.
In particular, we should be able in one single validation pass, to report about most known errors.
Also, validate should more resilient to spec errors and avoid panicking as much as possible.

Fix the following issues

A number of issues have already been posted about this.
This issue recaps the ones that might be short term improvements.

Add the following validation features

(not in other existing issues)

  • Improve checks on garbled path params ({x/y} , ..)
  • Check for path param uniqueness
  • Check path params are declared as required
  • Optional "continue on error" mode, to allow for checks to continue and sweep through all
    detected errors.
  • Replace regexp.MustCompile based on external output by simple compile and error management
  • More unit testing, with stricter assertions on errors, warnings and their numbers
  • Add check on multipleOf factor which must be positive
@fredbi
Copy link
Member Author

fredbi commented Dec 18, 2017

This list should be solved with PR #42

casualjim added a commit to go-swagger/go-swagger that referenced this issue Dec 22, 2017
…i/validate#44) (#1340)

* update vendor
* regenerate examples
* Support for continue on error in swagger validate (i.e. PR go-openapi/go-openapi#42)
@fredbi fredbi closed this as completed Dec 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant