Remove bytecopy from GetBody #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangcibot
reviewed
Mar 1, 2019
Codecov Report
@@ Coverage Diff @@
## master #131 +/- ##
==========================================
+ Coverage 80.59% 80.84% +0.25%
==========================================
Files 39 39
Lines 2231 2229 -2
==========================================
+ Hits 1798 1802 +4
+ Misses 341 335 -6
Partials 92 92
Continue to review full report at Codecov.
|
req.Body is already populated, and this, even on the first call, will write the payload again. Also adds a test guarding against the bug. Closes go-openapi#130 Signed-off-by: Bret Comnes <[email protected]>
bcomnes
added a commit
to netlify/open-api
that referenced
this pull request
Mar 1, 2019
See go-openapi/runtime#131 for upstream progress
casualjim
approved these changes
Mar 1, 2019
|
Thank you for the quick merge! |
bcomnes
added a commit
to netlify/open-api
that referenced
this pull request
Mar 1, 2019
This pins the openapi runtime to include our upstream bug fix: go-openapi/runtime#131 Remove the pin once a version > 0.18.0 is released.
bcomnes
added a commit
to netlify/open-api
that referenced
this pull request
Mar 1, 2019
This pins the openapi runtime to include our upstream bug fix: go-openapi/runtime#131 Remove the pin once a version > 0.18.0 is released.
bcomnes
added a commit
to netlify/open-api
that referenced
this pull request
Mar 1, 2019
This pins the openapi runtime to include our upstream bug fix: go-openapi/runtime#131 Remove the pin once a version > 0.18.0 is released.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
req.Body is already populated, and this, even on the first call, will write the payload again. It seems the solution is to just remove the byte copy all together.
Also adds a test guarding against the bug. Any feedback on the approach or style is appreciated :)
Closes #130