-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to set a parameter of type file as optional #246
Comments
yes please send a PR |
MakarandNsd
added a commit
to MakarandNsd/runtime
that referenced
this issue
Jun 14, 2022
@casualjim , can you please review the pr |
MakarandNsd
added a commit
to MakarandNsd/runtime
that referenced
this issue
Jun 27, 2022
MakarandNsd
added a commit
to MakarandNsd/runtime
that referenced
this issue
Jun 27, 2022
Signed-off-by: Makarand <[email protected]>
added test cases at #248 |
youyuanwu
added a commit
that referenced
this issue
Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I am not sure if no one needed this before, but I have a use case where the file type parameter is optional, but the code below returns error before validating whether the field is required.
runtime/middleware/parameter.go
Lines 206 to 213 in 3f9800f
I can throw in an additional if condition to check if the file is optional and return nil. Please let me know if that works.
The text was updated successfully, but these errors were encountered: