Merge pull request #200 from zeitlinger/opentracing_auth_info

fix nil pointer when auth info is nil

client/opentracing.go

@@ -41,6 +41,9 @@ func (t *tracingTransport) Submit(op *runtime.ClientOperation) (interface{}, err
 
 	op.AuthInfo = runtime.ClientAuthInfoWriterFunc(func(req runtime.ClientRequest, reg strfmt.Registry) error {
 		span = createClientSpan(op, req.GetHeaderParams(), t.host, t.opts)
+		if authInfo == nil {
+			return nil
+		}
 		return authInfo.AuthenticateRequest(req, reg)
 	})
 

client/opentracing_test.go

@@ -62,6 +62,19 @@ func Test_TracingRuntime_submit(t *testing.T) {
 	t.Parallel()
 	tracer := mocktracer.New()
 	_, ctx := opentracing.StartSpanFromContextWithTracer(context.Background(), tracer, "op")
+	testSubmit(t, testOperation(ctx), tracer)
+}
+
+func Test_TracingRuntime_submit_nullAuthInfo(t *testing.T) {
+	t.Parallel()
+	tracer := mocktracer.New()
+	_, ctx := opentracing.StartSpanFromContextWithTracer(context.Background(), tracer, "op")
+	operation := testOperation(ctx)
+	operation.AuthInfo = nil
+	testSubmit(t, operation, tracer)
+}
+
+func testSubmit(t *testing.T, operation *runtime.ClientOperation, tracer *mocktracer.MockTracer) {
 
 	header := map[string][]string{}
 	r := newOpenTracingTransport(&mockRuntime{runtime.TestClientRequest{Headers: header}},
@@ -71,7 +84,7 @@ func Test_TracingRuntime_submit(t *testing.T) {
 			Value: "service",
 		}})
 
-	_, err := r.Submit(testOperation(ctx))
+	_, err := r.Submit(operation)
 	require.NoError(t, err)
 
 	if assert.Len(t, tracer.FinishedSpans(), 1) {