Skip to content

Commit

Permalink
fix(ci): muted warnings in CI runs due to cache conflicts
Browse files Browse the repository at this point in the history
Every time a job is posted, I receive false alarm failure notifications because of some cache conflict during the linting job.

Reference: golangci/golangci-lint-action#807

* added unit tests to internal package

Signed-off-by: Frederic BIDON <[email protected]>
  • Loading branch information
fredbi committed Dec 26, 2023
1 parent 23cc9cc commit 91d0edd
Show file tree
Hide file tree
Showing 2 changed files with 41 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .github/workflows/go-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ jobs:
with:
version: latest
only-new-issues: true
skip-cache: true

test:
name: Unit tests
Expand All @@ -38,7 +39,7 @@ jobs:

- uses: actions/checkout@v3

- run: go test -v -race -coverprofile="coverage-${{ matrix.os }}.${{ matrix.go_version }}.out" -covermode=atomic ./...
- run: go test -v -race -coverprofile="coverage-${{ matrix.os }}.${{ matrix.go_version }}.out" -covermode=atomic -coverpkg=$(go list)/... ./...

- name: Upload coverage to codecov
uses: codecov/codecov-action@v3
Expand Down
39 changes: 39 additions & 0 deletions internal/normalize_url_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
package internal

import (
"net/url"
"testing"

"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)

func TestUrlnorm(t *testing.T) {
testCases := []struct {
url string
expected string
}{
{
url: "HTTPs://xYz.cOm:443/folder//file",
expected: "https://xyz.com/folder/file",
},
{
url: "HTTP://xYz.cOm:80/folder//file",
expected: "http://xyz.com/folder/file",
},
{
url: "postGRES://xYz.cOm:5432/folder//file",
expected: "postgres://xyz.com:5432/folder/file",
},
}

for _, toPin := range testCases {
testCase := toPin

u, err := url.Parse(testCase.url)
require.NoError(t, err)

NormalizeURL(u)
assert.Equal(t, testCase.expected, u.String())
}
}

0 comments on commit 91d0edd

Please sign in to comment.