Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

morph.go: ban global variables #34

Merged
merged 5 commits into from
Jan 13, 2022
Merged

morph.go: ban global variables #34

merged 5 commits into from
Jan 13, 2022

Conversation

isacikgoz
Copy link
Collaborator

@isacikgoz isacikgoz commented Jan 12, 2022 •
edited
Loading

agnivade
agnivade reviewed Jan 12, 2022
View reviewed changes
drivers/mysql/mysql.go Outdated Show resolved Hide resolved
drivers/postgres/postgres.go Outdated Show resolved Hide resolved
agnivade
agnivade approved these changes Jan 13, 2022
View reviewed changes
Copy link
Collaborator

@agnivade agnivade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some opportunities for refactoring. We can look into that later.

drivers/mysql/mysql_test.go Show resolved Hide resolved
drivers/mysql/mysql_test.go Show resolved Hide resolved
@isacikgoz isacikgoz merged commit a80086e into master Jan 13, 2022
@isacikgoz isacikgoz deleted the fix-race-config branch January 13, 2022 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agnivade agnivade agnivade approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isacikgoz @agnivade