Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Context support #42

Open
belak opened this issue Dec 2, 2016 · 4 comments
Open

Add Context support #42

belak opened this issue Dec 2, 2016 · 4 comments

Comments

@belak
Copy link
Member

belak commented Dec 2, 2016

No description provided.

@belak
Copy link
Member Author

belak commented Dec 6, 2016

I'm not really sure what this would look like... would the irc.Message have a context as well?

@bsdlp
Copy link

bsdlp commented Apr 29, 2017

at the very least, it would be great if the client.Run could take a context in order to support exiting the main loop.

belak added a commit that referenced this issue Jan 3, 2018
@belak
Add (*Client).RunContext to allow for cancelation
e927899 
Refs #42

This is the first step towards actual Context support in this library.
Next steps may involve passing a Context around with each message and
adding support to callbacks.
@belak belak mentioned this issue Jan 3, 2018
Merged
belak added a commit that referenced this issue Apr 10, 2018
@belak
Add (*Client).RunContext to allow for cancelation
2a61dc3 
Refs #42

This is the first step towards actual Context support in this library.
Next steps may involve passing a Context around with each message and
adding support to callbacks.
belak added a commit that referenced this issue Apr 10, 2018
@belak
Add (*Client).RunContext to allow for cancelation
3a984a1 
Refs #42

This is the first step towards actual Context support in this library.
Next steps may involve passing a Context around with each message and
adding support to callbacks.
@belak
Copy link
Member Author

belak commented Apr 10, 2018

This has (finally) been fixed with the addition of RunContext.

@belak belak closed this as completed Apr 10, 2018
@belak
Copy link
Member Author

belak commented Apr 10, 2018 •
edited
Loading

Reopening this because there's more that can be done with Context. What can I say, it's a Monday.

@belak belak reopened this Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@belak @bsdlp