Fix python multiline EOF error #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #309 +/- ##
==========================================
- Coverage 88.28% 88.20% -0.09%
==========================================
Files 9 9
Lines 1349 1348 -1
==========================================
- Hits 1191 1189 -2
Misses 96 96
- Partials 62 63 +1 |
gandarez
force-pushed
the
bugfix/python-multiline-eof
branch
2 times, most recently
from
d551d5d
to
acf928e
Compare
gandarez
force-pushed
the
bugfix/python-multiline-eof
branch
from
acf928e
to
41ca362
Compare
|
https://github.com/go-ini/ini/releases/tag/v1.66.1 has been tagged for this merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem should be fixed?
When parsing
python multilinevalues and the key which is being parsed is the last one on the ini file and there's no new line at the end, then it throws an error. To fix that we might not consider EOF as an error when reading the last line because it's either can be a\norEOF.This problem was first reported here.
Have you added test cases to catch the problem?
The
TestPythonMultiline_EOFwas added.