return empty series if metrics exist in index and has no points #240
Conversation
* fix: NaN is filled when index has no point - it is always filled either other index result has points or not
lordvidex
changed the title
- This was done to prevent issue go-graphite#235
- step1: test is failing - step2: tests are about 60% complete
- increased test coverage for `render` from 29.1% to 69.1%
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
render/reply/formatter_test.go
Outdated
| // result when CHResponse.AppendOutEmptySeries is false | ||
| expected0 []client.Metric | ||
| // result when CHResponse.AppendOutEmptySeries is true | ||
| expected1 []client.Metric |
There was a problem hiding this comment.
may be better expectedWithoutEmpty and expectedWithEmpty instead of magic names expected0 / expected1?
There was a problem hiding this comment.
I tried using names like this, but they sounded ambiguous too. In this case,
expected0 == expectedWithEmpty ?
There was a problem hiding this comment.
expected0 => expectedWithoutEmpty ?
| @@ -90,23 +93,8 @@ func (cc *CHResponses) ToMultiFetchResponseV2() (*v2pb.MultiFetchResponse, error | |||
| func (c *CHResponse) ToMultiFetchResponseV3() (*v3pb.MultiFetchResponse, error) { | |||
There was a problem hiding this comment.
ToMultiFetchResponseV2 also need changes for Null Points like ToMultiFetchResponseV3
| // result when CHResponse.AppendOutEmptySeries is true | ||
| expected1 []client.Metric | ||
| expectedWithoutEmpty []client.Metric |
There was a problem hiding this comment.
May be naming mistake and expectedWithoutEmpty <-> expectedWithtEmpty ?
// result when CHResponse.AppendOutEmptySeries is true
expected1 []client.Metric
expectedWithoutEmpty []client.Metric
msaf1980
changed the title
return empty series if metrics exist in index and has no points
Refs: #178