Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added 23503 pgerrcode support and updated the error conversion approach #185

Merged
merged 2 commits into from
May 19, 2023

Conversation

amirejaz75
Copy link
Contributor

  • [Y ] Do only one thing
  • [ Y] Non breaking API changes
  • [ Y] Tested

What did this pull request do?

Added 23503 pgerrcode support and updated the error conversion from pg error to gorm error approach

User Case Description

error_translator.go Outdated Show resolved Hide resolved
@saeidee
Copy link
Member

saeidee commented May 18, 2023

You may have conflict after merging this #179

error_translator.go Outdated Show resolved Hide resolved
@jinzhu jinzhu merged commit b320a5c into go-gorm:master May 19, 2023
@saeidee
Copy link
Member

saeidee commented May 19, 2023

@jinzhu could you please revert this, as it has not properly resolved the conflict with this #179 as well as needs to update gorm version to have the new error type.
image

@watson-sam
Copy link

@saeidee just opened an issue (#187) as hadnt seen yout above comment but this is indeed causing an error

@jinzhu
Copy link
Member

jinzhu commented May 19, 2023

@jinzhu could you please revert this, as it has not properly resolved the conflict with this #179 as well as needs to update gorm version to have the new error type. image

Can you submit the revert commit and release a new version?

(I haven't something wrong with my development machine ;(

saeidee pushed a commit to saeidee/postgres that referenced this pull request May 19, 2023
saeidee pushed a commit that referenced this pull request May 19, 2023
@saeidee
Copy link
Member

saeidee commented May 19, 2023

@codingamir feel free to create a new PR & thanks for contributing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants