-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't attempt to close issue if already closed #9696
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9696 +/- ##
==========================================
- Coverage 42.25% 42.24% -0.02%
==========================================
Files 590 590
Lines 78005 78004 -1
==========================================
- Hits 32961 32952 -9
- Misses 41001 41012 +11
+ Partials 4043 4040 -3
Continue to review full report at Codecov.
|
I would say backport ;) |
I always wait for the approvals and merge before backporting. You never know... 😁 |
sure :)
I thought about the **lable**
Am January 10, 2020 7:33:15 PM UTC schrieb guillep2k <[email protected]>:
…> >
> >
> I would say backport ;)>
>
I always wait for the approvals and merge before backporting. You never
know... 😁>
>
-- >
You are receiving this because you commented.>
Reply to this email directly or view it on GitHub:>
#9696 (comment)
|
@guillep2k Please send back port to v1.11 |
Fixes #9695
Couldn't reproduce, however, neither with a commit message or a text reference. Tested withmaster
(0c0ebe49ea4fd0d3ecc2aac9dfe2d7ce64381145) andv1.11.0-rc1
.Update
I can reproduce if the issue is closed from both the commit message and a text reference. This PR fixes that.