Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Errored PRs out of StatusChecking #9675

Merged
merged 5 commits into from
Jan 10, 2020

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Jan 9, 2020

One of the consequences of the fix in #9282 to ensure that PRs are rechecked is that an PR which errors in TestPatch will remain in StatusChecking. This previously didn't matter as PRs would never get rechecked whilst Gitea was running however now this means that these broken PRs will get repeatedly tested.

This PR moves these PRs to StatusError.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 9, 2020
@lafriks lafriks added this to the 1.12.0 milestone Jan 9, 2020
models/pull.go Outdated Show resolved Hide resolved
Co-Authored-By: John Olheiser <[email protected]>
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 9, 2020
@zeripath zeripath changed the title Set Errored PRs out of StatusChecking Move Errored PRs out of StatusChecking Jan 9, 2020
@codecov-io
Copy link

Codecov Report

Merging #9675 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9675      +/-   ##
==========================================
- Coverage   42.25%   42.25%   -0.01%     
==========================================
  Files         587      587              
  Lines       77991    77991              
==========================================
- Hits        32954    32952       -2     
- Misses      40995    40997       +2     
  Partials     4042     4042
Impacted Files Coverage Δ
modules/context/context.go 55.45% <0%> (ø) ⬆️
services/pull/check.go 53.42% <0%> (-3.43%) ⬇️
models/webhook.go 69.39% <0%> (-1.07%) ⬇️
routers/repo/view.go 39.47% <0%> (+0.87%) ⬆️
models/unit.go 67.56% <0%> (+5.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0baa47...80a4ad0. Read the comment docs.

@lunny lunny merged commit 17b844a into go-gitea:master Jan 10, 2020
@lunny
Copy link
Member

lunny commented Jan 10, 2020

Please send back port.

@zeripath zeripath deleted the if-error-set-pr-to-error-status branch January 10, 2020 07:28
zeripath added a commit to zeripath/gitea that referenced this pull request Jan 12, 2020
* Set Errored PRs out of StatusChecking

* Ensure that api status is correctly set too

* Update models/pull.go

Co-Authored-By: John Olheiser <[email protected]>

Co-authored-by: John Olheiser <[email protected]>
@sapk sapk added the backport/done All backports for this PR have been created label Jan 12, 2020
sapk pushed a commit that referenced this pull request Jan 12, 2020
* Move Errored PRs out of StatusChecking (#9675)

* Set Errored PRs out of StatusChecking

* Ensure that api status is correctly set too

* Update models/pull.go

Co-Authored-By: John Olheiser <[email protected]>

Co-authored-by: John Olheiser <[email protected]>

* Update services/pull/check.go

Co-authored-by: John Olheiser <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants