Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Slack webhook payload title generation to work with Mattermost #9404

Merged
merged 2 commits into from
Dec 18, 2019
Merged

Fix Slack webhook payload title generation to work with Mattermost #9404

merged 2 commits into from
Dec 18, 2019

Conversation

cornelk
Copy link
Contributor

@cornelk cornelk commented Dec 18, 2019

Backport of #9378

I was not able to start and test 1.10 locally due to panic: template: base/footer:15: function "StaticUrlPrefix" not defined.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 18, 2019
@lunny
Copy link
Member

lunny commented Dec 18, 2019

@cornelk you should build use TAGS="" make generate build. generate should be used on v1.10 but it could be ignored on v1.11 .

@lunny lunny added the type/bug label Dec 18, 2019
@lunny lunny added this to the 1.10.2 milestone Dec 18, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 18, 2019
@6543
Copy link
Member

6543 commented Dec 18, 2019

ping lgtm

@lunny lunny merged commit 3a14a69 into go-gitea:release/v1.10 Dec 18, 2019
@cornelk cornelk deleted the release/v1.10 branch April 15, 2020 21:17
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants