Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run fmt on files on master #9129

Merged
merged 1 commit into from
Nov 22, 2019
Merged

Conversation

davidsvantesson
Copy link
Contributor

When running make fmt on master this file (added in #8964) is modified (at least on linux and mingw).

Copy link
Member

@guillep2k guillep2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I encountered the same issue.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 22, 2019
@guillep2k
Copy link
Member

guillep2k commented Nov 22, 2019

Running make fmt on this branch works without changing any files now. 👍 (CentOS 7)

Copy link
Member

@jolheiser jolheiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also happened to me earlier.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 22, 2019
@zeripath
Copy link
Contributor

Sorry I relied on vscode and make release-windows to fix these for me - unfortunately I seem to be having a bit of trouble with the new go language server implementation and clearly it didn't run fmt on these.

@davidsvantesson
Copy link
Contributor Author

No problem, I was just surprised it wasn't catched by CI.

@zeripath zeripath merged commit a4e398d into go-gitea:master Nov 22, 2019
@techknowlogick techknowlogick added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Nov 22, 2019
@techknowlogick techknowlogick added this to the 1.11.0 milestone Nov 22, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants