Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On windows set core.longpaths true #8776

Merged
merged 5 commits into from
Nov 2, 2019
Merged

On windows set core.longpaths true #8776

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4ff99f8
On windows set core.longpaths true
zeripath Nov 1, 2019
9d3596d
Merge branch 'master' into fix-8744-windows-long-filenames
zeripath Nov 1, 2019
0b0135c
Merge branch 'master' into fix-8744-windows-long-filenames
zeripath Nov 2, 2019
98c0850
Merge branch 'master' into fix-8744-windows-long-filenames
lunny Nov 2, 2019
abd2ec0
Merge branch 'master' into fix-8744-windows-long-filenames
lunny Nov 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions modules/git/git.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ package git
import (
"fmt"
"os/exec"
"runtime"
"strings"
"time"

Expand Down Expand Up @@ -133,6 +134,13 @@ func Init() error {
return fmt.Errorf("Failed to execute 'git config --global gc.writeCommitGraph true': %s", stderr)
}
}

if runtime.GOOS == "windows" {
if _, stderr, err := process.GetManager().Exec("git.Init(git config --global core.longpaths true)",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried to find good documentation about this flag and what are the implications of setting it to true. The best I could find is this link, which doesn't talk about that but does a good explanation about where the feature comes from.

Copy link
Contributor Author

@zeripath zeripath Nov 2, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I too searched and it doesn't appear to be in the git source code.I suspect that this is something that they pass to mingw.

Just read your link and I see why I couldn't find it.

GitExecutable, "config", "--global", "core.longpaths", "true"); err != nil {
return fmt.Errorf("Failed to execute 'git config --global core.longpaths true': %s", stderr)
}
}
return nil
}

Expand Down