Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to merge if file path contains " or \ #8629

Merged
merged 9 commits into from
Nov 1, 2019
Merged

Allow to merge if file path contains " or \ #8629

merged 9 commits into from
Nov 1, 2019

Commits on Oct 22, 2019

  1. if a filename in a repository contains " or \ the owner can't merge p… 

    …ull request with this files

because "git diff-tree" adds double quotes to that filepath
example: filepath is ab"cd but "git diff-tree" returns "ab\"cd"

now, when the owner click "Merge Pull Request" button the server returns 500
this commit fix it

Signed-off-by: Ilya Pavlov <[email protected]>
    @Ilya33
    Ilya33 committed Oct 22, 2019
    Configuration menu
    Copy the full SHA
    a533b20 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2019

  1. add -z option to getDiffTree 

    escape spec symbols for sparse-checkout

Signed-off-by: Ilya Pavlov <[email protected]>
    @Ilya33
    Ilya33 committed Oct 26, 2019
    Configuration menu
    Copy the full SHA
    5b5a221 View commit details
    Browse the repository at this point in the history

  2. go fmt 

    Signed-off-by: Ilya Pavlov <[email protected]>
    @Ilya33
    Ilya33 committed Oct 26, 2019
    Configuration menu
    Copy the full SHA
    72c4e2f View commit details
    Browse the repository at this point in the history

  3. typo 

    Signed-off-by: Ilya Pavlov <[email protected]>
    @Ilya33
    Ilya33 committed Oct 26, 2019
    Configuration menu
    Copy the full SHA
    97c392c View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2019

  1. escape '\' 

    escape all spaces and '!'
    @Ilya33
    Ilya33 committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    893fc66 View commit details
    Browse the repository at this point in the history

  2. use regexp.ReplaceAllString() 

    Signed-off-by: Ilya Pavlov <[email protected]>
    @Ilya33
    Ilya33 committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    4794aff View commit details
    Browse the repository at this point in the history

  3. strings.ReplaceAll was added in go 1.12 

    Signed-off-by: Ilya Pavlov <[email protected]>
    @Ilya33
    Ilya33 committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    f8da2d8 View commit details
    Browse the repository at this point in the history

  4. add '\' to regexp.MustCompile 

    Signed-off-by: Ilya Pavlov <[email protected]>
    @Ilya33
    Ilya33 committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    df57695 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2019

  1. Merge branch 'master' into filepath-contains-spec-symbols

    @zeripath
    zeripath authored Oct 31, 2019
    Configuration menu
    Copy the full SHA
    1b1e257 View commit details
    Browse the repository at this point in the history