Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc recommend to use reverse proxy if Apache/nginx is also running on… #8384

Merged
merged 4 commits into from
Oct 9, 2019
Merged

Doc recommend to use reverse proxy if Apache/nginx is also running on… #8384

merged 4 commits into from
Oct 9, 2019

Conversation

8ctopus
Copy link
Contributor

@8ctopus 8ctopus commented Oct 5, 2019

My default goto when I wanted to setup https was the first option "Using the built-in server". I believe it can be useful to add a note that recommends the reverse proxy option if you already have a webserver running.

@codecov-io
Copy link

codecov-io commented Oct 5, 2019

Codecov Report

Merging #8384 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #8384      +/-   ##
=========================================
- Coverage    41.8%   41.8%   -0.01%     
=========================================
  Files         497     497              
  Lines       65571   65571              
=========================================
- Hits        27415   27412       -3     
- Misses      34643   34645       +2     
- Partials     3513    3514       +1
Impacted Files Coverage Δ
modules/log/file.go 75.52% <0%> (-2.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78438d3...db0ebdc. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 5, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 5, 2019
@lafriks lafriks added the type/docs This PR mainly updates/creates documentation label Oct 5, 2019
docs/content/doc/usage/https-support.md Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 7, 2019
@zeripath zeripath added this to the 1.10.0 milestone Oct 9, 2019
@zeripath zeripath merged commit 628f9da into go-gitea:master Oct 9, 2019
@8ctopus 8ctopus deleted the https-support branch October 10, 2019 04:19
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants