Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a comment typo #8358

Merged
merged 1 commit into from
Oct 2, 2019
Merged

Fix a comment typo #8358

merged 1 commit into from
Oct 2, 2019

Conversation

Tekaoh
Copy link
Contributor

@Tekaoh Tekaoh commented Oct 2, 2019

This pull request fixes a typo that I discovered in a code comment.

guillep2k
guillep2k approved these changes Oct 2, 2019
View reviewed changes
Copy link
Member

@guillep2k guillep2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code must remain vegan or at least vegetarian 😄

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 2, 2019
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@0d93430). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #8358   +/-   ##
=========================================
  Coverage          ?   41.76%           
=========================================
  Files             ?      496           
  Lines             ?    65585           
  Branches          ?        0           
=========================================
  Hits              ?    27389           
  Misses            ?    34682           
  Partials          ?     3514
Impacted Files Coverage Δ
routers/repo/wiki.go 40.88% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d93430...0b395b1. Read the comment docs.

jolheiser
jolheiser approved these changes Oct 2, 2019
View reviewed changes
Copy link
Member

@jolheiser jolheiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But what if the wiki was about meat? We'd need the meat information then!

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 2, 2019
@techknowlogick techknowlogick added this to the 1.10.0 milestone Oct 2, 2019
@techknowlogick techknowlogick merged commit e3eb9fa into go-gitea:master Oct 2, 2019
@techknowlogick techknowlogick added the type/docs This PR mainly updates/creates documentation label Oct 2, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@guillep2k guillep2k guillep2k approved these changes

@jolheiser jolheiser jolheiser approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Tekaoh @codecov-io @guillep2k @jolheiser @techknowlogick @GiteaBot