Fix mirror repository webhooks #7366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7366 +/- ##
==========================================
- Coverage 41.24% 41.24% -0.01%
==========================================
Files 467 467
Lines 63295 63298 +3
==========================================
Hits 26108 26108
- Misses 33770 33773 +3
Partials 3417 3417
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
zeripath
approved these changes
Jul 6, 2019
GiteaBot
added
lgtm/need 1
techknowlogick
approved these changes
Jul 6, 2019
GiteaBot
added
lgtm/done
lafriks
approved these changes
Jul 6, 2019
lunny
reviewed
Jul 7, 2019
| @@ -896,6 +896,11 @@ func mirrorSyncAction(e Engine, opType ActionType, repo *Repository, refName str | |||
| }); err != nil { | |||
| return fmt.Errorf("notifyWatchers: %v", err) | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
You should move these to https://github.com/go-gitea/gitea/blob/master/models/action.go#L943 because it should be with webhook.
jeffliu27
pushed a commit
to jeffliu27/gitea
that referenced
this pull request
Jul 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5441
I found that mirror syncs will properly create hook tasks, however, the hook queue that gitea is monitoring is never updated/notified of the hook task for the repo and thus the hook task is never fulfilled. If you restart the gitea server, the goroutine first fulfills the current task list and then blocks on the hook queue. This is why any mirror action webhooks are sent on restart and why any new hook tasks created by mirror actions do not get fulfilled automatically.
Signed-off-by: Drew Kowalski [email protected]