Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: static url #6341

Closed
wants to merge 4 commits into from
Closed

WIP: static url #6341

wants to merge 4 commits into from

Conversation

lunny
Copy link
Member

@lunny lunny commented Mar 16, 2019

This PR will allow static resources served by another domain different from the main domain. So that a CDN service could be used easier.

@lunny lunny changed the title WIIP: static url WIP: static url Mar 16, 2019
@adelowo
Copy link
Member

adelowo commented Mar 16, 2019

We should add it to the docs too not just ini.sample

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 16, 2019
@stale
Copy link

stale bot commented May 15, 2019

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

@stale stale bot added the issue/stale label May 15, 2019
@lunny lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Jul 7, 2019
@stale stale bot removed the issue/stale label Jul 7, 2019
@lunny lunny added this to the 1.10.0 milestone Jul 7, 2019
@lunny lunny added the type/enhancement An improvement of existing functionality label Jul 7, 2019
das7pad
das7pad reviewed Aug 18, 2019
View reviewed changes
modules/templates/helper.go
"DiffLineTypeToStr": DiffLineTypeToStr,
"Sha1": Sha1,
"ShortSha": base.ShortSha,
"MD5": base.EncodeMD5,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run go fmt

Diff: das7pad@f219cac

@das7pad
Copy link
Contributor

das7pad commented Aug 18, 2019

Hi @lunny, I continued your work over at this branch lunny/static_url in my fork.

All resources from /public should be converted by now, as in replacing {{AppSubUrl}}/PATH -> {{StaticUrlPrefix}}/PATH with PATH being css, img, js, less (no hit here), vendor.

@lunny
Copy link
Member Author

lunny commented Aug 19, 2019

Please send a new PR to gitea.

@das7pad das7pad mentioned this pull request Aug 19, 2019
Merged
@das7pad
Copy link
Contributor

das7pad commented Aug 19, 2019

PR landed in #7911

@lunny lunny closed this Aug 29, 2019
@lunny lunny deleted the lunny/static_url branch August 29, 2019 04:58
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@das7pad das7pad das7pad left review comments

Assignees
No one assigned
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.
6 participants
@lunny @adelowo @das7pad @GiteaBot @zeripath @techknowlogick