Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix go-get URL generation #5905

Merged
merged 1 commit into from
Jan 30, 2019
Merged

Fix go-get URL generation #5905

merged 1 commit into from
Jan 30, 2019

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Jan 30, 2019

No description provided.

@lafriks lafriks added this to the 1.8.0 milestone Jan 30, 2019
zeripath
zeripath approved these changes Jan 30, 2019
View reviewed changes
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't believe this wasn't there already.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 30, 2019
@codecov-io
Copy link

Codecov Report

Merging #5905 into master will increase coverage by 0.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5905      +/-   ##
==========================================
+ Coverage   37.99%   38.01%   +0.01%     
==========================================
  Files         328      328              
  Lines       48343    48343              
==========================================
+ Hits        18369    18377       +8     
+ Misses      27335    27326       -9     
- Partials     2639     2640       +1
Impacted Files Coverage Δ
modules/context/repo.go 59.57% <0%> (ø) ⬆️
modules/context/context.go 49.4% <0%> (ø) ⬆️
models/repo.go 44.45% <100%> (ø) ⬆️
routers/repo/view.go 47.3% <0%> (+1.19%) ⬆️
models/repo_list.go 64.55% <0%> (+1.26%) ⬆️
models/unit.go 14.28% <0%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57a69ef...e92d32e. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 30, 2019
@zeripath zeripath merged commit 80098bd into go-gitea:master Jan 30, 2019
@zeripath
Copy link
Contributor

@lafriks can you backport?

@lafriks lafriks deleted the fix/go-get-url branch January 30, 2019 21:13
lafriks added a commit to lafriks-fork/gitea that referenced this pull request Jan 30, 2019
@lafriks
Fix go-get URL generation (go-gitea#5905)
891c4b7
@lafriks lafriks mentioned this pull request Jan 30, 2019
Merged
@lafriks
Copy link
Member Author

lafriks commented Jan 30, 2019

@zeripath done

@lafriks lafriks added the backport/done All backports for this PR have been created label Jan 30, 2019
lafriks added a commit that referenced this pull request Jan 30, 2019
@lafriks
Fix go-get URL generation (#5905) (#5907)
3f802a2
@lafriks lafriks added the topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! label Jan 31, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@sapk sapk sapk approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! type/bug
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lafriks @codecov-io @zeripath @sapk @GiteaBot