Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SQL quoting #5137

Merged
merged 1 commit into from
Oct 22, 2018
Merged

Conversation

filipnavara
Copy link
Contributor

Backport of #5117.

show is keyword in MySQL and has to be quoted to reference a column name. Use grave accents (ASCII code 96) for quoting to match rest of the source code. It's non-standard SQL, but it's supported by SQLite and MySQL.

`show` is keyword in MySQL and has to be quoted to reference a column name. Use grave accents (ASCII code 96) for quoting to match rest of the source code. It's non-standard SQL, but it's supported by SQLite and MySQL.

Signed-off-by: Filip Navara <[email protected]>
@lafriks lafriks added this to the 1.6.0 milestone Oct 22, 2018
@lafriks
Copy link
Member

lafriks commented Oct 22, 2018

Make LG-TM work

@lafriks lafriks added type/bug lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 22, 2018
@lafriks
Copy link
Member

lafriks commented Oct 22, 2018

Does lgtm work already? :)

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 22, 2018
@techknowlogick techknowlogick merged commit 7238bb3 into go-gitea:release/v1.6 Oct 22, 2018
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants