-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch built-in SSH server to github.com/gliderlabs/ssh #3896
Conversation
5f96450
to
a6ecd78
Compare
CI failed. |
9be2d48
to
c0b5a7f
Compare
Codecov Report
@@ Coverage Diff @@
## master #3896 +/- ##
==========================================
- Coverage 38.73% 37.42% -1.31%
==========================================
Files 339 312 -27
Lines 49013 46323 -2690
==========================================
- Hits 18983 17338 -1645
+ Misses 27284 26509 -775
+ Partials 2746 2476 -270
Continue to review full report at Codecov.
|
Sorry about that. Managed to figure out how to run drone locally and fixed the issues I saw - most notably, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update to use dep
I've been really busy lately but I still plan on updating this. I don't know if I can give a specific date though. |
Signed-off-by: Kaleb Elwert <[email protected]>
Signed-off-by: Kaleb Elwert <[email protected]>
Signed-off-by: Kaleb Elwert <[email protected]>
c0b5a7f
to
5a4eec8
Compare
This has been updated to use dep, though there were some oddities with the Godep.lock file which seems like it added something for all existing deps as well. Not sure how that should be handled. |
The lock file seems fine. Those additions are probably just from a newer version of dep. |
@belak any update? |
I'll get that change into gliderlabs/ssh which should let us have the same level of granularity with the internal algorithms (though I'm not 100% we need to expose that) and then fix up the Gopkg files. Is there anything else that needs to be done I'm missing? |
d3abd6a
to
ae2e406
Compare
My apologies, I completely forgot about this. I'd be happy to clean this up some time this week. |
@belak no need to apologize, we appreciate your PR, and I'm the one who should be sorry as we should've done a better job of reviewing your PR sooner. I'm just going through right now and doing some maintenance patches on older PRs so they aren't conflicted and make it easier for them to get reviewed, so I hope you don't mind that I pushed directly to your branch. |
resolves git conflicts from #3896 (credit to @belak, in case github doesn't keep original author during squash) Co-Authored-By: Matti Ranta <[email protected]>
resolves git conflicts from go-gitea#3896 (credit to @belak, in case github doesn't keep original author during squash) Co-Authored-By: Matti Ranta <[email protected]>
This pull request is the first step towards making the built-in SSH server a good option. As discussed in discord, gliderlabs/ssh does a fairly good job at abstracting away most of the error-prone
x/crypto/ssh
code while still maintaining the flexibility we need.A few things worth noting:
cmd/serv.go
probably isn't needed (I can revert it if requested), but may be worthwhile anyway. I was using that before I was properly shell escaping command arguments.cmd/serv.go
directly, rather than having to call it like this. That would allow us to avoid re-escaping command args as they come in.If anyone has a recommended test suite or things they'd like to see tested, please let me know and I will do my best.