Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update blackfriday dependency per #2994 #3857

Merged
merged 3 commits into from
Apr 29, 2018
Merged

Update blackfriday dependency per #2994 #3857

merged 3 commits into from
Apr 29, 2018

Conversation

pjeby
Copy link
Contributor

@pjeby pjeby commented Apr 28, 2018

Signed-off-by: PJ Eby [email protected]

This PR is a pure update of the vendored blackfriday markdown processor, to fix various bugs as described in #2994, including HTML5 validity, infinite loops on certain input, and commonmark compatibility for code fence lines.

@pjeby
Copy link
Contributor Author

pjeby commented Apr 28, 2018

Btw, the test failure here is the documentation build issue addressed by PR #3856.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 28, 2018
@thehowl
Copy link
Contributor

thehowl commented Apr 28, 2018

LGTM

@thehowl
Copy link
Contributor

thehowl commented Apr 28, 2018

make LG-TM work ✨

@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 28, 2018
@codecov-io
Copy link

codecov-io commented Apr 28, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@76106ab). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #3857   +/-   ##
========================================
  Coverage          ?     23%           
========================================
  Files             ?     126           
  Lines             ?   24892           
  Branches          ?       0           
========================================
  Hits              ?    5726           
  Misses            ?   18289           
  Partials          ?     877

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76106ab...b70f47e. Read the comment docs.

@lunny
Copy link
Member

lunny commented Apr 29, 2018

LGTM

@lunny lunny mentioned this pull request Apr 29, 2018
Closed
1 task
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 29, 2018
@lunny lunny added this to the 1.5.0 milestone Apr 29, 2018
@lunny lunny merged commit fc36567 into go-gitea:master Apr 29, 2018
@pjeby pjeby deleted the blackfriday-update branch May 6, 2018 02:58
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
5 participants
@pjeby @thehowl @codecov-io @lunny @bkcsoft