Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Avatar Border for Visual Consistency #32574

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

kerwin612
Copy link
Member

For the ① mentioned in the comment (#32565 (comment)).

Add a border to the Avatar to avoid poor visual experiences caused by irregularly sized images.

before:
image

after:
image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 20, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 20, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Nov 20, 2024
@lunny
Copy link
Member

lunny commented Nov 20, 2024

The new design looks a bit off—there are two overlapping borders.

@wxiaoguang
Copy link
Contributor

To be honest, the border is more ugly than before

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 20, 2024
@kerwin612
Copy link
Member Author

To be honest, the border is more ugly than before

This is indeed a matter of "choice". No matter how one chooses, there will always be some who find it suitable and some who don't. This is quite normal, and I fully understand it.

Currently:
1732090781438

After adding the border:
1732090730917
(issues such as border style can be adjusted additionally)

I think we should first make a choice and confirm whether we need borders.
If it's confirmed that borders are needed, I will continue to improve this PR. If not, I will close this PR.

@lunny @wxiaoguang

@github-actions github-actions bot removed the modifies/go Pull requests that update Go code label Nov 20, 2024
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Nov 20, 2024

I think we should first make a choice and confirm whether we need borders. If it's confirmed that borders are needed, I will continue to improve this PR. If not, I will close this PR.

I would say no to current state, these screenshots look more ugly.

image

image

@lunny
Copy link
Member

lunny commented Nov 20, 2024

Maybe we can use a circle with border which is how Github did.
profile small
image

participants
image

profile big
image

@silverwind
Copy link
Member

silverwind commented Nov 20, 2024

I personally dislike both circling and border, with circling being the more severe of the two. If there is a border, there should also be a subtle background change. And it wouldn't fit in all places, like on the user page where it looks strange imho with the double border.

When GitHub introduced the circles around 2 years ago, they visually broke a lot of avatars where essential parts of the avatar were cut off. So it's a somewhat breaking change too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/need 1 This PR needs approval from one additional maintainer to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants