-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Avatar Border for Visual Consistency #32574
base: main
Are you sure you want to change the base?
Conversation
The new design looks a bit off—there are two overlapping borders. |
To be honest, the border is more ugly than before |
I personally dislike both circling and border, with circling being the more severe of the two. If there is a border, there should also be a subtle background change. And it wouldn't fit in all places, like on the user page where it looks strange imho with the double border. When GitHub introduced the circles around 2 years ago, they visually broke a lot of avatars where essential parts of the avatar were cut off. So it's a somewhat breaking change too. |
For the ① mentioned in the comment (#32565 (comment)).
Add a border to the Avatar to avoid poor visual experiences caused by irregularly sized images.
before:
after: