Update the list of watchers and stargazers when clicking watch/unwatch or star/unstar

[yardenshoham]

We make sure the user cards are updated

• Fixes Clicking Star/Unstar, Watch/Unwatch buttons on star list or watch list page result in inconsistent result. #32561

I also removed ctx.Data["PageIsWatchers"] = true and ctx.Data["PageIsStargazers"] = true as they are not used anywhere.

Before

After

[wxiaoguang]

I would still strongly prefer to reload the whole page, instead of adding more special code (and the new code has no test code / is hard to test)

[delvh]

I'm not sure if we should mix HTMX terminology directly into Gitea:
It looks like the /cards routes always (re-)render a list of users.
To me as a reader of the code, the /cards prefix reads strange.
I can understand it in this PR as it is HTMX focused, but the moment it is merged you won't have that context anymore.
So, perhaps we can find another name for it.

But functionality-wise LGTM.

[silverwind]

What happens to any potential JS event handlers in the swapped HTML when HTMX does the swap? How do we make sure that event handlers that need to be added to new cards are bound correctly after the swap? Likely there are currently no such event handlers, but it is something that must be considered when doing such swaps.

[yardenshoham]

This is true for any HTMX swap. This pull request is not the first one. There are no event handlers attached to the cards so we should be ok.

[wxiaoguang]

It seems that it could use hx-select to partially reloading, then no need to add these /cards endpoints.

[yardenshoham]

i will try it

[wxiaoguang]

Just pushed 🤣

Managed to get it work in da86679, only a few changed lines now

[wxiaoguang]

One more thing, it should use CurrentURL but not Link, because there could be "page" query parameters.