Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move AddCollabrator and CreateRepositoryByExample to service layer #32419

Merged
merged 13 commits into from
Nov 7, 2024

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 4, 2024

  • Move CreateRepositoryByExample to service layer
  • Move AddCollabrator to service layer
  • Add a new parameter for AddCollabrator so that changing mode immediately after that will become unnecessary.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Nov 4, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 4, 2024
@pull-request-size pull-request-size bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 4, 2024
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Nov 4, 2024
@lunny lunny force-pushed the lunny/refactor-collaboration branch from c200c38 to 9a6b396 Compare November 4, 2024 18:58
modules/repository/main_test.go Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 5, 2024
@lunny lunny added this to the 1.23.0 milestone Nov 6, 2024
@yp05327
Copy link
Contributor

yp05327 commented Nov 7, 2024

title: Move AddCollabrator and CreateRepositoryByExample to service layer

@lunny lunny changed the title Move AddCollabrator functions to service layer Move AddCollabrator and CreateRepositoryByExample to service layer Nov 7, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 7, 2024
@lunny lunny merged commit 276500c into go-gitea:main Nov 7, 2024
26 checks passed
@lunny lunny deleted the lunny/refactor-collaboration branch November 7, 2024 03:28
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 10, 2024
* giteaofficial/main:
  Refactor sidebar label selector (go-gitea#32460)
  Fix mermaid diagram height when initially hidden (go-gitea#32457)
  Add reviewers selection to new pull request (go-gitea#32403)
  Fix issue sidebar (go-gitea#32455)
  Refactor language menu and dom utils (go-gitea#32450)
  Fix broken releases when re-pushing tags (go-gitea#32435)
  Refactor issue page info (go-gitea#32445)
  Split issue sidebar into small templates (go-gitea#32444)
  Only provide the commit summary for Discord webhook push events (go-gitea#32432)
  Add new event commit status creation and webhook implementation (go-gitea#27151)
  Support quote selected comments to reply (go-gitea#32431)
  Move AddCollabrator and CreateRepositoryByExample to service layer (go-gitea#32419)

# Conflicts:
#	templates/repo/issue/view_content/context_menu.tmpl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants