Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add null check for responseData.invalidTopics (#32212) #32217

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

GiteaBot
Copy link
Contributor

@GiteaBot GiteaBot commented Oct 8, 2024

Backport #32212 by @cloudchamb3r

Screenshot 2024-10-08 at 10 49 10 AM

responseData.invalidTopics can be null but it wasn't handled.

<img width="553" alt="Screenshot 2024-10-08 at 10 49 10 AM"
src="https://github.com/user-attachments/assets/faeef64d-684a-4aba-b7fc-c7c6a0301abe">

`responseData.invalidTopics` can be null but it wasn't handled.
@GiteaBot GiteaBot added this to the 1.22.3 milestone Oct 8, 2024
@GiteaBot GiteaBot requested a review from delvh October 8, 2024 17:27
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 8, 2024
@GiteaBot GiteaBot requested a review from lunny October 8, 2024 17:27
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 8, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 8, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 9, 2024
@lunny lunny merged commit 4815c4a into go-gitea:release/v1.22 Oct 9, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend modifies/js size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants