Ensure GetCSRF
doesn't return an empty token (#32130)
#32157
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #32130 by @wolfogre
Since page templates keep changing, some pages that contained forms with CSRF token no longer have them.
It leads to some calls of
GetCSRF
returning an empty string, which fails the tests. Likegitea/tests/integration/attachment_test.go
Lines 62 to 63 in 3269b04
The test did try to get the CSRF token and provided it, but it was empty.