Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect /tokens api #32085

Merged
merged 7 commits into from
Sep 20, 2024
Merged

Fix incorrect /tokens api #32085

merged 7 commits into from
Sep 20, 2024

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Sep 19, 2024

Fixes #32078

  • Add missing scopes output.
  • Disallow empty scope.

@KN4CK3R
Add missing scopes output.
560b444 
Disallow empty scope.
@KN4CK3R KN4CK3R added type/bug backport/v1.22 This PR should be backported to Gitea 1.22 labels Sep 19, 2024
@KN4CK3R KN4CK3R added this to the 1.23.0 milestone Sep 19, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 19, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 19, 2024
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Sep 19, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 19, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 19, 2024
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 20, 2024
@KN4CK3R KN4CK3R enabled auto-merge (squash) September 20, 2024 11:15
@wxiaoguang wxiaoguang enabled auto-merge (squash) September 20, 2024 14:59
@lunny lunny disabled auto-merge September 20, 2024 18:28
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 20, 2024
@lunny lunny enabled auto-merge (squash) September 20, 2024 18:32
@lunny lunny merged commit 08adbc4 into go-gitea:main Sep 20, 2024
26 checks passed
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Sep 20, 2024
@KN4CK3R @lunny @GiteaBot
Fix incorrect /tokens api (go-gitea#32085)
0110f3b 
Fixes go-gitea#32078

- Add missing scopes output.
- Disallow empty scope.

---------

Co-authored-by: Lunny Xiao <[email protected]>
@GiteaBot GiteaBot mentioned this pull request Sep 20, 2024
Merged
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Sep 20, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 21, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
19aa38d 
* giteaofficial/main:
  Fix incorrect `/tokens` api (go-gitea#32085)
  Set manual `tabindex`es on login page (go-gitea#31689)
  Only use Host header from reverse proxy (go-gitea#32060)
  [skip ci] Updated translations via Crowdin
KN4CK3R added a commit that referenced this pull request Sep 22, 2024
@GiteaBot @KN4CK3R
Fix incorrect /tokens api (#32085) (#32092)
919b824 
Backport #32085 by @KN4CK3R

Fixes #32078

- Add missing scopes output.
- Disallow empty scope.

Co-authored-by: KN4CK3R <[email protected]>
@KN4CK3R KN4CK3R deleted the fix-token-api-32078 branch October 15, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lafriks lafriks lafriks left review comments

@lunny lunny lunny approved these changes

@delvh delvh delvh approved these changes

@wolfogre wolfogre wolfogre approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

Incomplete API POST reponse for scopes in /api/v1/users/<user>/tokens
7 participants
@KN4CK3R @lunny @lafriks @wolfogre @delvh @GiteaBot @wxiaoguang