Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase cacheContextLifetime to reduce false reports (#32011) #32023

Merged
merged 1 commit into from
Sep 11, 2024

Commits on Sep 10, 2024

  1. Increase cacheContextLifetime to reduce false reports (go-gitea#32011)

    Replace go-gitea#32001.
    
    To prevent the context cache from being misused for long-term work
    (which would result in using invalid cache without awareness), the
    context cache is designed to exist for a maximum of 10 seconds. This
    leads to many false reports, especially in the case of slow SQL.
    
    This PR increases it to 5 minutes to reduce false reports.
    
    5 minutes is not a very safe value, as a lot of changes may have
    occurred within that time frame. However, as far as I know, there has
    not been a case of misuse of context cache discovered so far, so I think
    5 minutes should be OK.
    
    Please note that after this PR, if warning logs are found again, it
    should get attention, at that time it can be almost 100% certain that it
    is a misuse.
    wolfogre authored and GiteaBot committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    d1ac56a View commit details
    Browse the repository at this point in the history