Fix /repos/{owner}/{repo}/pulls/{index}/files endpoint not populating previous_filename
#32017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
charles-plutohealth
force-pushed
the
main
branch
2 times, most recently
from
63ec5e4
to
a68a874
Compare
lunny
approved these changes
Sep 9, 2024
GiteaBot
added
lgtm/need 1
Huh? |
|
yp05327
approved these changes
Sep 10, 2024
GiteaBot
added
lgtm/done
charles-plutohealth
force-pushed
the
main
branch
from
a68a874
to
5962056
Compare
delvh
approved these changes
Sep 10, 2024
|
failures in |
lunny
added
the
reviewed/wait-merge
|
@charles-plutohealth please fix the merge conflicts. 🍵 |
GiteaBot
removed
the
reviewed/wait-merge
charles-plutohealth
force-pushed
the
main
branch
from
8af547a
to
a468cf4
Compare
… previous_filename
charles-plutohealth
force-pushed
the
main
branch
from
a468cf4
to
9964526
Compare
lunny
added
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Sep 11, 2024
…ng `previous_filename` (go-gitea#32017) --- `status == "rename"` should have read `status == "renamed"`. The typo means that file.PreviousFilename would never be populated, which e.g. breaks usage of the Github Action at https://github.com/dorny/paths-filter.
GiteaBot
removed
the
reviewed/wait-merge
yp05327
pushed a commit
that referenced
this pull request
Sep 11, 2024
…ng `previous_filename` (#32017) (#32028) Backport #32017 by @charles-plutohealth --- `status == "rename"` should have read `status == "renamed"`. The typo means that file.PreviousFilename would never be populated, which e.g. breaks usage of the Github Action at https://github.com/dorny/paths-filter. Co-authored-by: charles-plutohealth <[email protected]>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Sep 12, 2024
* giteaofficial/main: [skip ci] Updated translations via Crowdin Failed authentications are logged to level Warning (go-gitea#32016) Fix `/repos/{owner}/{repo}/pulls/{index}/files` endpoint not populating `previous_filename` (go-gitea#32017) Support allowed hosts for migrations to work with proxy (go-gitea#32025) Support migration from AWS CodeCommit (go-gitea#31981) bump to go 1.23 (go-gitea#31855) Enable compression for Actions logs by default (go-gitea#32013) Save initial signup information for users to aid in spam prevention (go-gitea#31852) Increase `cacheContextLifetime` to reduce false reports (go-gitea#32011)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
status == "rename"should have readstatus == "renamed". The typo means that file.PreviousFilename would never be populated, which e.g. breaks usage of the Github Action at https://github.com/dorny/paths-filter.