Prevent update pull refs manually and will not affect other refs update (#31931) #31955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te (go-gitea#31931) All refs under `refs/pull` should only be changed from Gitea inside but not by pushing from outside of Gitea. This PR will prevent the pull refs update but allow other refs to be updated on the same pushing with `--mirror` operations. The main changes are to add checks on `update` hook but not `pre-receive` because `update` will be invoked by every ref but `pre-receive` will revert all changes once one ref update fails.
GiteaBot
added
modifies/cli
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
lunny
approved these changes
Sep 2, 2024
GiteaBot
added
lgtm/need 1
a1012112796
approved these changes
Sep 2, 2024
GiteaBot
added
lgtm/done
wolfogre
approved these changes
Sep 2, 2024
wolfogre
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #31931 by @lunny
All refs under
refs/pullshould only be changed from Gitea inside but not by pushing from outside of Gitea.This PR will prevent the pull refs update but allow other refs to be updated on the same pushing with
--mirroroperations.The main changes are to add checks on
updatehook but notpre-receivebecauseupdatewill be invoked by every ref butpre-receivewill revert all changes once one ref update fails.