Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix upload maven pacakge parallelly #31851

Merged
merged 12 commits into from
Sep 21, 2024
Merged

Fix upload maven pacakge parallelly #31851

merged 12 commits into from
Sep 21, 2024

Conversation

lunny
Copy link
Member

@lunny lunny commented Aug 16, 2024 •
edited
Loading

Use globallock for maven package uploads.

Thanks @tlusser for the test code.

Depends on #31813

@lunny lunny added type/bug backport/v1.22 This PR should be backported to Gitea 1.22 labels Aug 16, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 16, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 16, 2024
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Aug 16, 2024
@techknowlogick
Copy link
Member

Could this be applied to the docker image push too?

@lunny
Copy link
Member Author

lunny commented Aug 17, 2024

Could this be applied to the docker image push too?

The logic can be similar but the endpoint will not be the same. So, I would like to fix them one by one.

@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 19, 2024
@wolfogre
Copy link
Member

Wait for #31908?

@lunny
Copy link
Member Author

lunny commented Aug 26, 2024

Depends on #31813

@lunny lunny removed the backport/v1.22 This PR should be backported to Gitea 1.22 label Aug 26, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 30, 2024
@wolfogre
Copy link
Member

The tests panic because the default lock hasn't been initialized until #31813.

@lunny lunny added the backport/v1.22 This PR should be backported to Gitea 1.22 label Aug 30, 2024
@wolfogre
Copy link
Member

wolfogre commented Sep 2, 2024

Hmm, it cannot be backported to v1.22 since it depends on #31813. Or we need to fix it in another way.

@lunny
Copy link
Member Author

lunny commented Sep 2, 2024

Hmm, it cannot be backported to v1.22 since it depends on #31813. Or we need to fix it in another way.

I will use the old lock in backpor PR.

@lunny lunny mentioned this pull request Sep 2, 2024
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Sep 2, 2024
lunny added a commit that referenced this pull request Sep 3, 2024
@lunny
Add lock for parallel maven upload (#31954)
9c990ac 
Backport #31851 
Fix #30171
@lunny lunny removed the backport/v1.22 This PR should be backported to Gitea 1.22 label Sep 6, 2024
@lunny lunny modified the milestones: 1.22.3, 1.23.0 Sep 6, 2024
@lunny lunny removed type/bug backport/done All backports for this PR have been created labels Sep 6, 2024
@lunny lunny added the type/bug label Sep 20, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 21, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 21, 2024
@lunny lunny enabled auto-merge (squash) September 21, 2024 18:22
@lunny lunny merged commit 5de4173 into go-gitea:main Sep 21, 2024
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 21, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 23, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
521030e 
* giteaofficial/main:
  [skip ci] Updated licenses and gitignores
  Fix rename branch permission bug (go-gitea#32066)
  Fix artifact v4 upload above 8MB (go-gitea#31664)
  [skip ci] Updated translations via Crowdin
  Add bin to Composer Metadata (go-gitea#32099)
  Fix wrong last modify time (go-gitea#32102)
  Fix upload maven pacakge parallelly (go-gitea#31851)
  Repo Activity: count new issues that were closed (go-gitea#31776)
  Count typescript files as frontend for labeling (go-gitea#32088)
  Use camo.Always instead of camo.Allways (go-gitea#32097)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yp05327 yp05327 yp05327 approved these changes

@wolfogre wolfogre wolfogre approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lunny @techknowlogick @wolfogre @yp05327 @GiteaBot