Avoid returning without written ctx when posting PR (#31843) #31848
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #31843 by @wolfogre
Fix #31625.
If
pull_service.NewPullRequest
return an error which misses eachif
check,CompareAndPullRequestPost
will return immediately, since it doesn't write the HTTP response, a 200 response with empty body will be sent to clients.Not sure what kind of error can cause it to happen, so this PR just expose it. And we can fix it when users report that creating PRs failed with error responses.
It's all my guess since I cannot reproduce the problem, but even if it's not related, the code here needs to be improved.