Refactor the usage of batch catfile #31754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
type/bug
type/refactoring
pull-request-size
bot
added
the
size/L
GiteaBot
added
the
lgtm/need 2
lunny
changed the title
lunny
force-pushed
the
lunny/fix_possible_catfile
branch
from
015fd4a
to
7041756
Compare
lunny
added
performance/cpu
backport/v1.22
…y git calls in openrepository
wolfogre
approved these changes
Aug 5, 2024
GiteaBot
added
lgtm/need 1
yp05327
reviewed
Aug 19, 2024
yp05327
reviewed
Aug 19, 2024
yp05327
approved these changes
Aug 20, 2024
GiteaBot
added
lgtm/done
I will try to merge the two functions in following PRs |
lunny
added
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Aug 20, 2024
When opening a repository, it will call `ensureValidRepository` and also `CatFileBatch`. But sometimes these will not be used until repository closed. So it's a waste of CPU to invoke 3 times git command for every open repository. This PR removed all of these from `OpenRepository` but only kept checking whether the folder exists. When a batch is necessary, the necessary functions will be invoked.
GiteaBot
added
backport/done
silverwind
pushed a commit
that referenced
this pull request
Aug 20, 2024
Backport #31754 by @lunny When opening a repository, it will call `ensureValidRepository` and also `CatFileBatch`. But sometimes these will not be used until repository closed. So it's a waste of CPU to invoke 3 times git command for every open repository. This PR removed all of these from `OpenRepository` but only kept checking whether the folder exists. When a batch is necessary, the necessary functions will be invoked. Co-authored-by: Lunny Xiao <[email protected]>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Aug 21, 2024
* giteaofficial/main: [skip ci] Updated translations via Crowdin Refactor the usage of batch catfile (go-gitea#31754) Fix agit automerge (go-gitea#31207)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When opening a repository, it will call
ensureValidRepositoryand alsoCatFileBatch. But sometimes these will not be used until repository closed. So it's a waste of CPU to invoke 3 times git command for every open repository.This PR removed all of these from
OpenRepositorybut only kept checking whether the folder exists. When a batch is necessary, the necessary functions will be invoked.