Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the display of project type for deleted projects #31732

Merged
merged 3 commits into from
Jul 30, 2024
Merged

Fix the display of project type for deleted projects #31732

merged 3 commits into from
Jul 30, 2024

Conversation

yp05327
Copy link
Contributor

@yp05327 yp05327 commented Jul 30, 2024

Fix: #31727
After:
image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 30, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 30, 2024
@github-actions github-actions bot added modifies/translation modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels Jul 30, 2024
@yp05327 yp05327 added topic/ui Change the appearance of the Gitea UI backport/v1.22 This PR should be backported to Gitea 1.22 type/bug and removed modifies/translation modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels Jul 30, 2024
@github-actions github-actions bot added modifies/translation modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels Jul 30, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 30, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 30, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jul 30, 2024
@lunny lunny enabled auto-merge (squash) July 30, 2024 04:10
@lunny lunny merged commit 75d0b61 into go-gitea:main Jul 30, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Jul 30, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Jul 30, 2024
@yp05327 @GiteaBot
Fix the display of project type for deleted projects (go-gitea#31732)
df56af0 
Fix: go-gitea#31727
After:

![image](https://github.com/user-attachments/assets/1dfb4b31-3bd6-47f7-b126-650f33f453e2)
@GiteaBot GiteaBot mentioned this pull request Jul 30, 2024
Merged
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Jul 30, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jul 30, 2024
lunny pushed a commit that referenced this pull request Jul 30, 2024
@GiteaBot @yp05327
Fix the display of project type for deleted projects (#31732) (#31734)
8591c91 
Backport #31732 by @yp05327

Fix: #31727
After:

![image](https://github.com/user-attachments/assets/1dfb4b31-3bd6-47f7-b126-650f33f453e2)

Co-authored-by: yp05327 <[email protected]>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jul 31, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
f387831 
* giteaofficial/main:
  Improve names of cron jobs for Actions (go-gitea#31736)
  [skip ci] Updated translations via Crowdin
  Fix the display of project type for deleted projects (go-gitea#31732)
  Fix Null Pointer error for CommitStatusesHideActionsURL (go-gitea#31731)
  Move `registerActionsCleanup` to `initActionsTasks` (go-gitea#31721)
@yp05327 yp05327 deleted the fix-deleted-project-display branch August 12, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@wolfogre wolfogre wolfogre approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files modifies/translation size/S Denotes a PR that changes 10-29 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

Deleting projects causes bad popover text on issues
4 participants
@yp05327 @lunny @wolfogre @GiteaBot