Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "Filter by commit" Dropdown #31695

Merged
merged 6 commits into from
Jul 25, 2024
Merged

Fix "Filter by commit" Dropdown #31695

merged 6 commits into from
Jul 25, 2024

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Jul 24, 2024 •
edited
Loading

Regression of #31281 (code by me)

Fix #31673

image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 24, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 24, 2024
@wxiaoguang wxiaoguang mentioned this pull request Jul 24, 2024
Closed
@wxiaoguang wxiaoguang added type/bug backport/v1.22 This PR should be backported to Gitea 1.22 labels Jul 24, 2024
@silverwind
Copy link
Member

There is a double border-top in the screenshot. I assume existing bug?

@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 24, 2024
@wxiaoguang wxiaoguang added backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! labels Jul 24, 2024
@wxiaoguang wxiaoguang mentioned this pull request Jul 24, 2024
Merged
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 24, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 24, 2024
@wxiaoguang wxiaoguang enabled auto-merge (squash) July 24, 2024 14:25
@yp05327 yp05327 added this to the 1.23.0 milestone Jul 24, 2024
wxiaoguang added a commit that referenced this pull request Jul 25, 2024
@wxiaoguang
Fix "Filter by commit" Dropdown (#31695) (#31696)
0fb1c1f 
A separate backport of #31695 for 1.22
Fix #31673
@wxiaoguang wxiaoguang merged commit 169031b into go-gitea:main Jul 25, 2024
26 checks passed
@wxiaoguang wxiaoguang deleted the fix-commit-dropdown branch July 25, 2024 01:55
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jul 25, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
b8fd763 
* giteaofficial/main:
  Fix "Filter by commit" Dropdown (go-gitea#31695)
  [skip ci] Updated translations via Crowdin
@wxiaoguang wxiaoguang mentioned this pull request Aug 22, 2024
Closed
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@KN4CK3R KN4CK3R KN4CK3R approved these changes

@silverwind silverwind silverwind approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/js size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

PR Files changed view: "Filter by commit" Dropdown not visible after clicking the button
6 participants
@wxiaoguang @silverwind @lunny @KN4CK3R @yp05327 @GiteaBot