Fix web notification icon not updated once you read all notifications

[kiatt210]

Fix #29065
Remove status filtering from GetUIDsAndNotificationCounts sql.

[wxiaoguang]

Could you add some details about how it fixes the problem? TBH I haven't caught the point 🤣

[kiatt210]

I'm sorry, of course 🙂

When the number of unread notifications becomes 0, the original SQL query does not return the user's row.
As a result, there will not be a new notification-count event to update the icon. With this modification, the user's row will be included in the result with 0 count, and the event will be triggered.

The event generation :

uidCounts, err := activities_model.GetUIDsAndNotificationCounts(ctx, then, now)
if err != nil {
	log.Error("Unable to get UIDcounts: %v", err)
}
for _, uidCount := range uidCounts {
	m.SendMessage(uidCount.UserID, &Event{
		Name: "notification-count",
		Data: uidCount,
	})
}

[wxiaoguang]

Overall LGTM

The details could be written into comments.

[kiatt210]

I need to find out how to get the missing UIDs, but I am going to try.

Thanks for the idea!

[wxiaoguang]

Read the code again, it seems that it is impossible to figure out the non-existing IDs quickly.

So current method should be good enough. Let's try it.