Refactor image diff #31444
Refactor image diff #31444
Conversation
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
github-actions
bot
added
modifies/templates
wxiaoguang
added
the
type/refactoring
wxiaoguang
force-pushed
the
refactor-image-diff
branch
from
0ca3d5a
to
1c73e5c
Compare
web_src/js/features/common-form.js
Outdated
| @@ -1,4 +1,5 @@ | |||
| import $ from 'jquery'; | |||
| import '../vendor/jquery.are-you-sure.js'; | |||
There was a problem hiding this comment.
Already imported in web_src/js/features/common-global.js, so this would load it twice needlessly.
Move import to index.js?
There was a problem hiding this comment.
There is no common-global.js
There was a problem hiding this comment.
Where is it currently loaded? Not at all?
There was a problem hiding this comment.
Move import to index.js?
I would say no. Only use it where it is really used. Here is initGlobalFormDirtyLeaveConfirm
There was a problem hiding this comment.
0678287 regressed it. I recommend moving the import to top of index.js, it's needed on so many pages, we may as well load it everywhere.
There was a problem hiding this comment.
I will rewrite the are-you-sure in next PR, but not in this one.
There was a problem hiding this comment.
-> Fix are-you-sure #31446
There was a problem hiding this comment.
Maybe we do not need that many PRs, merged #31446 into this since it is simple enough
GiteaBot
added
lgtm/need 1
| boundsInfoAfterHeight.classList.toggle('green', heightChanged); | ||
| } | ||
| const widthChanged = sizes.imageAfter && sizes.imageBefore && sizes.imageAfter.naturalWidth !== sizes.imageBefore.naturalWidth; | ||
| const heightChanged = sizes.imageAfter && sizes.imageBefore && sizes.imageAfter.naturalHeight !== sizes.imageBefore.naturalHeight; |
There was a problem hiding this comment.
Can these two lines be simplified to sizes.imageAfter?.naturalWidth !== sizes.imageBefore?.naturalWidth?
There was a problem hiding this comment.
No, the meaning is different.
GiteaBot
added
lgtm/done
* giteaofficial/main: Refactor image diff (go-gitea#31444) [skip ci] Updated translations via Crowdin Support relative paths to videos from Wiki pages (go-gitea#31061) Fix deprecated Dockerfile ENV format (go-gitea#31450) README Badge maintenance (go-gitea#31441) Improve markdown textarea for indentation and lists (go-gitea#31406) Split common-global.js into separate files (go-gitea#31438)
|
Regression? At https://demo.gitea.com/, maybe it is out of date. 
|
|
No, 621e1ff is a quite old commit |
|
a4899ff got deployed and error is gone. Which commit fixed it? |
|
@silverwind the binary release had an issue for a sec, so the updates didn't get pushed to demo. it's since been resolved. |
And remove some jQuery functions