Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new issue/pr avatar (#31419) #31424

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

GiteaBot
Copy link
Contributor

Backport #31419 by @silverwind

The avatar on "New Issue" and "New Pull Request" pages was inconsistent. Removed the extra margin and the new CSS rules now use common parent <form id="#new-issue"> because .repository.new.issue is not present on pull request page.

Before:

Screenshot 2024-06-19 at 13 56 17 Screenshot 2024-06-19 at 13 54 02

After:

Screenshot 2024-06-19 at 13 54 16 Screenshot 2024-06-19 at 13 54 22

The avatar on "New Issue" and "New Pull Request" pages was inconsistent.
Removed the extra margin and the new CSS rules now use common parent
`<form id="#new-issue">` because `.repository.new.issue` is not present
on pull request page.
@GiteaBot GiteaBot added topic/ui Change the appearance of the Gitea UI type/bug labels Jun 19, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 19, 2024
@GiteaBot GiteaBot added this to the 1.22.1 milestone Jun 19, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 19, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 19, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 19, 2024
@silverwind silverwind enabled auto-merge (squash) June 19, 2024 21:13
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 19, 2024
@silverwind silverwind merged commit 5c79c2b into go-gitea:release/v1.22 Jun 19, 2024
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 19, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants