-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing menu active item background back #30897
Conversation
Not sure if this is a complete fix. I will check later. In v1.21, this style was provided by this rule: .ui.menu .active.item,
.ui.menu .active.item:hover,
.ui.vertical.menu .active.item,
.ui.vertical.menu .active.item:hover {
color: var(--color-text);
background: var(--color-active);
} Somehow this must have gotten lost during #30325 or another PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking until I verified this.
I have checked there is And I think current UI looks good enough so there is no need to add Feel free to double check and edit this PR if necessary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Another option may be to remove .ui.vertical.menu .item { background: none }
, but I'm not sure whether this has side-effects.
Backport #30897 by wxiaoguang Co-authored-by: wxiaoguang <[email protected]>
* giteaofficial/main: Add missing menu active item background back (go-gitea#30897) Fix misspelling of mergable (go-gitea#30896) Fix incorrect issue form (go-gitea#30881) Update issue indexer after merging a PR (go-gitea#30715) Fix various problems around projects board view (go-gitea#30696) Fix wrong transfer hint (go-gitea#30889) Remove obsolete monaco workaround (go-gitea#30893)
Fix #30578