Enable npm cache on setup-node action
#30577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
silverwind
changed the title
setup-nodesetup-node action
techknowlogick
approved these changes
Apr 18, 2024
GiteaBot
added
lgtm/need 1
silverwind
changed the title
setup-node actionsetup-node action
lunny
approved these changes
Apr 19, 2024
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
lunny
added
backport/v1.21
|
I was unable to create a backport for 1.21. @silverwind, please send one manually. 🍵 |
GiteaBot
added
the
backport/manual
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Apr 19, 2024
Enable npm dependency cache in [setup-node](https://github.com/actions/setup-node). This should work reliably and across branches as well.
GiteaBot
removed
the
reviewed/wait-merge
lunny
pushed a commit
to lunny/gitea
that referenced
this pull request
Apr 19, 2024
Enable npm dependency cache in [setup-node](https://github.com/actions/setup-node). This should work reliably and across branches as well.
silverwind
added a commit
that referenced
this pull request
Apr 19, 2024
Backport #30577 by @silverwind Enable npm dependency cache in [setup-node](https://github.com/actions/setup-node). This should work reliably and across branches as well. Co-authored-by: silverwind <[email protected]>
|
Appears to work, my only concern is that architecture is not part of the cache filename, so it likely wouldn't work on a ARM runner. |
I filed actions/setup-node#1008 for this. |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 19, 2024
* giteaofficial/main: Fix project description rendering for org (go-gitea#30587) Fix changelog (main) (go-gitea#30582) Avoid importing `modules/web/middleware` in `modules/session` (go-gitea#30584) Enable npm cache on `setup-node` action (go-gitea#30577)
lunny
added a commit
that referenced
this pull request
Apr 22, 2024
Backport #30577 Enable npm dependency cache in [setup-node](https://github.com/actions/setup-node). This should work reliably and across branches as well. --------- Co-authored-by: silverwind <[email protected]>
wxiaoguang
added
the
skip-changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable npm dependency cache in setup-node. This should work reliably and across branches as well.