Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix label rendering (#30456) #30460

Merged
merged 1 commit into from
Apr 13, 2024
Merged

Fix label rendering (#30456) #30460

merged 1 commit into from
Apr 13, 2024

Conversation

GiteaBot
Copy link
Contributor

@GiteaBot GiteaBot commented Apr 13, 2024 •
edited by wxiaoguang
Loading

Backport #30456 by wxiaoguang

  1. Check whether the label is for an issue or a pull request.
  2. Don't use space to layout
  3. Make sure the test strings have trailing spaces explicitly, to avoid some IDE removing the trailing spaces automatically.

@wxiaoguang @GiteaBot
Fix label rendering (go-gitea#30456)
9d42f1c 
1. Check whether the label is for an issue or a pull request.
2. Don't use space to layout
3. Make sure the test strings have trailing spaces explicitly, to avoid
some IDE removing the trailing spaces automatically.
@GiteaBot GiteaBot added modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files type/bug labels Apr 13, 2024
@GiteaBot GiteaBot added this to the 1.22.0 milestone Apr 13, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 13, 2024
@GiteaBot GiteaBot requested review from delvh and lunny April 13, 2024 10:05
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 13, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 13, 2024
@wxiaoguang wxiaoguang enabled auto-merge (squash) April 13, 2024 10:07
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 13, 2024
@wxiaoguang wxiaoguang merged commit 846888f into go-gitea:release/v1.22 Apr 13, 2024
26 checks passed
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@delvh delvh Awaiting requested review from delvh

@lunny lunny Awaiting requested review from lunny

Assignees

@wxiaoguang wxiaoguang

Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
3 participants
@GiteaBot @silverwind @wxiaoguang